You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Previously we were able to (I believe) inventory via tiles and dates (i.e. without a shapefile). The above results in only inventorying the data for the first tile. This seems like a bug.
I see that gips.core.SpatialExtent.factory returns a list of SpatialExtent objects, always. Seems like DataInventory.__init__ should handle (or always expect) the spatial extent being a list of SpatialExtent objects; OR SpatialExtent should internally keep track of the list of extents, and thus factory would return one SpatialExtent. I'm aesthetically drawn to the latter, but architectural constraints might necessitate the former.
What do you think, Matt?
The text was updated successfully, but these errors were encountered:
ircwaves
changed the title
gips.inventory.DataInventory.inventory with tile list only
gips.inventory.DataInventory.inventory with tile list only
Apr 28, 2015
Ah yes, that was a work around to maintain the old behavior.
Think of it this way, if SpatialExtent were itself a collection of extents, then those individual extents should also be their own object. That would make SpatialExtent a container object, which really should contain other objects, otherwise your object is doing a lot of extra stuff.
Now, if a collection of spatial extents might have their own unique properties all together, then one might consider a new SpatialExtents object, that might have it's own functions in addition to normal list functions but I'm not sure what those would be.
Really the issue here is that any particular dataset .inventory function should actually return a list of DataInventories, because the input can now be 1+ geometries rather than 1.
Based on this block (from here):
Previously we were able to (I believe) inventory via tiles and dates (i.e. without a shapefile). The above results in only inventorying the data for the first tile. This seems like a bug.
I see that
gips.core.SpatialExtent.factory
returns a list of SpatialExtent objects, always. Seems likeDataInventory.__init__
should handle (or always expect) the spatial extent being a list ofSpatialExtent
objects; ORSpatialExtent
should internally keep track of the list of extents, and thusfactory
would return oneSpatialExtent
. I'm aesthetically drawn to the latter, but architectural constraints might necessitate the former.What do you think, Matt?
The text was updated successfully, but these errors were encountered: