Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the eslint warnings #28

Open
periclestavares opened this issue Sep 23, 2019 · 2 comments
Open

Fix the eslint warnings #28

periclestavares opened this issue Sep 23, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@periclestavares
Copy link

periclestavares commented Sep 23, 2019

Fix the eslint warnings:

./src/components/Header.tsx
Line 13: Using target="_blank" without rel="noopener noreferrer" is a security risk: see https://mathiasbynens.github.io/rel-noopener react/jsx-no-target-blank

./src/index.tsx
Line 16: 'version' is assigned a value but never used @typescript-eslint/no-unused-vars

./src/services/trader.service.ts
Line 1: 'StoryId' is defined but never used @typescript-eslint/no-unused-vars

./src/components/StoryDetails.tsx
Line 1: 'KeyboardEvent' is defined but never used @typescript-eslint/no-unused-vars
Line 5: 'ContentEditable' is defined but never used @typescript-eslint/no-unused-vars

./src/redux/reducers/index.ts
Line 2: 'sprintsReducer' is defined but never used @typescript-eslint/no-unused-vars
Line 3: 'teamsReducer' is defined but never used @typescript-eslint/no-unused-vars
Line 4: 'teamMembersReducer' is defined but never used @typescript-eslint/no-unused-vars
Line 6: 'Sprint' is defined but never used @typescript-eslint/no-unused-vars
Line 7: 'TeamMember' is defined but never used @typescript-eslint/no-unused-vars
Line 8: 'Team' is defined but never used @typescript-eslint/no-unused-vars

./src/components/StoryList.tsx
Line 3: 'addStory' is defined but never used @typescript-eslint/no-unused-vars
Line 3: 'removeStory' is defined but never used @typescript-eslint/no-unused-vars
Line 3: 'selectStory' is defined but never used @typescript-eslint/no-unused-vars
Line 3: 'removeTask' is defined but never used @typescript-eslint/no-unused-vars

./src/components/TaskItem.tsx
Line 4: 'Icon' is defined but never used @typescript-eslint/no-unused-vars

./src/redux/actions.ts
Line 62: 'addTeam' is defined but never used @typescript-eslint/no-unused-vars
Line 69: 'updateTeam' is defined but never used @typescript-eslint/no-unused-vars
Line 76: 'removeTeam' is defined but never used @typescript-eslint/no-unused-vars
Line 88: 'addTeamMember' is defined but never used @typescript-eslint/no-unused-vars
Line 95: 'updateTeamMember' is defined but never used @typescript-eslint/no-unused-vars
Line 102: 'removeTeamMember' is defined but never used @typescript-eslint/no-unused-vars

./src/components/StoryListItem.tsx
Line 62: 'storyIndex' is assigned a value but never used @typescript-eslint/no-unused-vars
Line 62: 'deleteStory' is assigned a value but never used @typescript-eslint/no-unused-vars

@gilesv gilesv added the good first issue Good for newcomers label Oct 1, 2019
@miguelcarvalho13
Copy link

@periclestavares @gilesv Should those warnings be removed or fixed?

@periclestavares periclestavares changed the title Remove the eslint warnings Fix the eslint warnings Oct 3, 2019
@periclestavares
Copy link
Author

@miguelcarvalho13 fixed. I updated the title and description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants