Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent backups of the android-sdk archive #29

Closed
wants to merge 3 commits into from

Conversation

rjaros87
Copy link
Contributor

I have added attribute default['android-sdk']['backup_archive'] with false value to prevent backups of the android-sdk archive. I think is not neccessary to kept backup of the android-sdk archive.

Below is description of the backup attribute (which is used in the ark resource).

backup

Ruby Types: FalseClass, Integer

The number of backups to be kept in `/var/chef/backup` (for UNIX- and Linux-based platforms) or `C:/chef/backup` (for the Microsoft Windows platform). Set to false to prevent backups from being kept. Default value: 5.

@rjaros87 rjaros87 force-pushed the prevent_archive_backups branch 6 times, most recently from 9a7c5f5 to 9be98c7 Compare June 23, 2016 10:58
@rjaros87
Copy link
Contributor Author

rjaros87 commented Jun 23, 2016

@gildegoma please review.
In this PR I exclude rule 053 from foodcritic, please see https://docs.chef.io/config_rb_metadata.html#settings recommends and also rise the ruby version from 2.0 to 2.1 because chef 12.11 not supports Ruby < 2.1

@gildegoma
Copy link
Owner

@rjaros87 Thanks for all this ❤️. I'll do my best to review it very soon, but at first glance this looks pretty neat and cool!

@gildegoma
Copy link
Owner

Closed in favour of #33 (including these changes as well).

@gildegoma gildegoma closed this Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants