Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement best practices for linkerd-multicluster-link app #2319

Closed
4 tasks done
Tracked by #2066
LolloneS opened this issue Apr 5, 2023 · 1 comment
Closed
4 tasks done
Tracked by #2066

Implement best practices for linkerd-multicluster-link app #2319

LolloneS opened this issue Apr 5, 2023 · 1 comment
Assignees
Labels
team/cabbage Team Cabbage

Comments

@LolloneS
Copy link

LolloneS commented Apr 5, 2023

Coming from here.

The goal of this issue is to have the App eventually adhere to standard cloud-native best-practices. The points below are to be considered non-exhaustive. Feel free to add some that make sense and remove some that don't. If this issue does not make sense (e.g. is a duplicate or covers a deprecated app) please close it.

Expected outcome:

  • the app has properly set PDBs (as percentages)
  • the app can scale horizontally based on Custom Metrics (if it makes sense)
  • the app runs with more than 1 replica by default (if it needs HA)
  • the app does not use emptyDir volumes if not strictly necessary
@LolloneS LolloneS added the team/cabbage Team Cabbage label Apr 5, 2023
@ced0ps ced0ps added QoLI Quality of Liveimprovements and removed QoLI Quality of Liveimprovements labels Jul 11, 2023
@mcharriere mcharriere self-assigned this Aug 15, 2023
@mcharriere
Copy link

the app has properly set PDBs (as percentages)
the app can scale horizontally based on Custom Metrics (if it makes sense)
the app runs with more than 1 replica by default (if it needs HA)

All this implemented in linkerd/linkerd2#11047 . We'll pull these changes during the next upgrade.

the app does not use emptyDir volumes if not strictly necessary

app needs emptyDir enabled cluster-wide. This is a problem as our default policy is blocking that. see https://github.com/giantswarm/giantswarm/issues/21039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/cabbage Team Cabbage
Projects
None yet
Development

No branches or pull requests

3 participants