Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement best practices for default-apps-aws app #2306

Closed
4 tasks
Tracked by #2066
LolloneS opened this issue Apr 5, 2023 · 4 comments
Closed
4 tasks
Tracked by #2066

Implement best practices for default-apps-aws app #2306

LolloneS opened this issue Apr 5, 2023 · 4 comments

Comments

@LolloneS
Copy link

LolloneS commented Apr 5, 2023

Coming from here.

The goal of this issue is to have the App eventually adhere to standard cloud-native best-practices. The points below are to be considered non-exhaustive. Feel free to add some that make sense and remove some that don't. If this issue does not make sense (e.g. is a duplicate or covers a deprecated app) please close it.

Expected outcome:

  • the app has properly set PDBs (as percentages)
  • the app can scale horizontally based on Custom Metrics (if it makes sense)
  • the app runs with more than 1 replica by default (if it needs HA)
  • the app does not use emptyDir volumes if not strictly necessary
@fiunchinho
Copy link
Member

@LolloneS the default-apps-aws is a bundle of apps that installs the default apps required in a cluster. It's not an app in itself, so I don't think this issue makes sense for default-apps-aws. Before closing it, I'd like a confirmation from your side, because I may be missing something.

@LolloneS
Copy link
Author

Looking at the apps inside default-apps-aws I see:

appName: aws-ebs-csi-driver
appName: aws-pod-identity-webhook
appName: capi-node-labeler
appName: cert-exporter
appName: cert-manager
appName: coredns
appName: cilium
appName: external-dns
appName: metrics-server
appName: net-exporter
appName: node-exporter
appName: vertical-pod-autoscaler
appName: vertical-pod-autoscaler-crd
appName: observability-bundle

Most of these apps already have their issues assigned to the appropriate teams. Do you see any app owned by hydra that could use a sanity check on whether it's well configured? If yes, I can open an issue for that specific app, otherwise we close this one and we're good :)

@fiunchinho
Copy link
Member

I don't think we have any other managed apps. The rest of the apps we own are only deployed to MCs.

@LolloneS
Copy link
Author

Then we're good to close. Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants