Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement best practices for aws-cloud-controller-manager-app app #2302

Closed
4 tasks done
Tracked by #2066
LolloneS opened this issue Apr 5, 2023 · 2 comments
Closed
4 tasks done
Tracked by #2066

Implement best practices for aws-cloud-controller-manager-app app #2302

LolloneS opened this issue Apr 5, 2023 · 2 comments
Labels
team/phoenix Team Phoenix

Comments

@LolloneS
Copy link

LolloneS commented Apr 5, 2023

Coming from here.

The goal of this issue is to have the App eventually adhere to standard cloud-native best-practices. The points below are to be considered non-exhaustive. Feel free to add some that make sense and remove some that don't. If this issue does not make sense (e.g. is a duplicate or covers a deprecated app) please close it.

Expected outcome:

  • the app has properly set PDBs (as percentages)
  • the app can scale horizontally based on Custom Metrics (if it makes sense)
  • the app runs with more than 1 replica by default (if it needs HA)
  • the app does not use emptyDir volumes if not strictly necessary
@JosephSalisbury
Copy link
Contributor

yo @T-Kukawka any chance we can close / kill here? the overarching issue is hanging

@T-Kukawka
Copy link
Contributor

This is the daemonset with VPA enabled by default, each Control Plane is running separate instance, no volumes in use hence no EmptyDirs. No actions here, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/phoenix Team Phoenix
Projects
Archived in project
Development

No branches or pull requests

3 participants