Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement best practices for fluent-logshipping-app app #2287

Closed
4 tasks done
Tracked by #2066
LolloneS opened this issue Apr 5, 2023 · 1 comment
Closed
4 tasks done
Tracked by #2066

Implement best practices for fluent-logshipping-app app #2287

LolloneS opened this issue Apr 5, 2023 · 1 comment

Comments

@LolloneS
Copy link

LolloneS commented Apr 5, 2023

Coming from here.

The goal of this issue is to have the App eventually adhere to standard cloud-native best-practices. The points below are to be considered non-exhaustive. Feel free to add some that make sense and remove some that don't. If this issue does not make sense (e.g. is a duplicate or covers a deprecated app) please close it.

Expected outcome:

  • the app has properly set PDBs (as percentages)
  • the app can scale horizontally based on Custom Metrics (if it makes sense)
  • the app runs with more than 1 replica by default (if it needs HA)
  • the app does not use emptyDir volumes if not strictly necessary
@QuentinBisson
Copy link

fluent-logshipping-app is not using any emptyDir
fluent-logshipping-app is a DaemonSet and so does not PDBs and it's very unlikely this will ever make it kubernetes/kubernetes#108124
fluent-logshipping-app is a DaemonSet so the number of replicas cannot be changed, it's always 1 per node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants