-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not sure how to proceed with CrowdStrike.wxs file #1
Comments
I get the same error when wrapping the latest installer, but the resulting MSI still functions as intended. It looks like it is safe to ignore the error, but if I can dig in and better understand the WIX interface and how the XML config controls this, it may be possible to modify the XML in such a way that it no longer generates the error. Will update you if I figure it out. |
Treat the error as a warning. You can probably fix it by modifying the XML to conform with the specification: https://wixtoolset.org/documentation/manual/v3/xsd/wix/property.html. Basically the wrapper here will still work. I'm not absolutely sure of sensitivity of a Customer ID Checksum but it seems it remains on a falcon host unencrypted after install so I don't think its that big of a risk to hardcode it if your new MSI is kept internal (or MDM servers). Given this I think the best solution here is to modify the property xml element to contain a value attribute with your CID. Please do your own research on this though as I may be wrong about the sensitivity of the CID. |
@giannello Thank you for the template :-) It worked very well for me! |
@JonEmmons292 unless you're compiling it with a new version of Wix than the one I've tested, you shouldn't get any warning. Could you please provide some kind of log where you get this warning? @LiamKearn your solution could work, but will make the resulting MSI only usable for your CS instance. This wrapper is meant to be generic, and anyone with your CID could register a host to your Falcon instance. I'd rather not do that, but up to you. If the Falcon installer filename changed in the meantime, feel free to open a PR with the name change :) I'm currently not using this anymore, as I moved to greener pastures, but I'm keeping the repo for our fellow Workspace MDM admins in need of a solution |
First thanks for posting the instructions for packaging the CrowdStrike EXE. I'm running into an issue similiar to your post. I ran through the ReadMe file and hitting a wall on how best to proceed. I have all the prerequisites ready. I copied the contents of your CrowdStrike.wxs file to my local workstation. My issue lies in the wxs file. Should I be changing the options in the file to match setup? Like Property ID= CID or Guid? Also my file name is different but I changed that and it seemed to be ok. I can run through the steps and I get a MSI but it doesn't report in correctly to the CrowdStrike server. I also get an error when generated the wix.obj file.
warning CNDL1006 : Property 'CID' does not contain a Value attribute and is not marked as Admin, Secure, or Hidden. The Property element is being ignored.
This seems to point to the CID variable as an issue. Sorry for all the questions but this is my first stab at using Wix and I'm a bit confused. Any help would be greatly appreciated.
The text was updated successfully, but these errors were encountered: