Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More nomenclature issues: particle_id_pair #9

Open
Jintram opened this issue May 13, 2011 · 2 comments
Open

More nomenclature issues: particle_id_pair #9

Jintram opened this issue May 13, 2011 · 2 comments

Comments

@Jintram
Copy link

Jintram commented May 13, 2011

This apparently has nothing to do with a pair in the sense of an eGFRD particle pair in a domain. It just holds particle info.

@YetAnotherTomek
Copy link
Member

Hi,

yes, we know that issue, this naming is indeed somewhat unfortunate. The
reason is that there is a boost object called pair which is just a pair
of two objects of arbitrary different type. particle_id_pair is using
this structure. The name however is misleading. They should have named
it particle_id_tuple or something similar. But changing this now all
over the code will be tricky...

Regards

Tomek

On 05/13/2011 04:50 PM, Jintram wrote:

This apparently has nothing to do with a pair in the sense of an eGFRD particle pair in a domain. It just holds particle info.

@thomie
Copy link
Collaborator

thomie commented May 17, 2011

particle_id_tuple would be a better name

On Fri, May 13, 2011 at 4:50 PM, Jintram <
[email protected]>wrote:

This apparently has nothing to do with a pair in the sense of an eGFRD
particle pair in a domain. It just holds particle info.

Reply to this email directly or view it on GitHub:
#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants