Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboards): Implement BigNumberWidget Badge feature #78944

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

gggritso
Copy link
Member

@gggritso gggritso commented Oct 10, 2024

Contribute to #77779

e.g.,
Screenshot 2024-10-10 at 12 02 06 PM

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 10, 2024
@gggritso gggritso marked this pull request as ready for review October 10, 2024 16:04
@gggritso gggritso requested a review from a team as a code owner October 10, 2024 16:04
Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, lgtm

`badgeProps` is clearer, and is an established pattern. We often do
`XProps` if the props are relevant so a sub-component only.
@gggritso gggritso merged commit c5f8497 into master Oct 16, 2024
43 checks passed
@gggritso gggritso deleted the feat/dashboards/widget-frame-badge branch October 16, 2024 14:46
cmanallen pushed a commit that referenced this pull request Oct 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants