Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature-flag "release-like" UI to issue details page #77812

Closed
cmanallen opened this issue Sep 19, 2024 · 0 comments · Fixed by #78147
Closed

Add feature-flag "release-like" UI to issue details page #77812

cmanallen opened this issue Sep 19, 2024 · 0 comments · Fixed by #78147
Assignees
@michellewzhang
Labels
enhancement

Comments

@cmanallen
Copy link
Member

This PR only requires vertical lines be drawn on the issue volume graphs. The lines correspond to flag definition changes. Those changes can be found on the endpoints defined in the blueprint.

Blueprint PR. Feel free to review and request changes prior to starting work!
Design doc.
@michellewzhang michellewzhang mentioned this issue Sep 25, 2024
Merged
michellewzhang added a commit that referenced this issue Oct 7, 2024
@michellewzhang
feat(flags): add flag series to event graph (#78147)
21978e3 
adds release-like lines for feature flag changes on top of the event bar
chart. there is a legend to toggle the feature flag lines on and off.

new legend to match the figma:

<img width="377" alt="SCR-20241004-kija"
src="https://github.com/user-attachments/assets/a0c1f0d5-8751-4b41-9e34-d8bcd2c7add8">


the video below shows the graph with mock data with the 3 types of
possible flag actions - created, updated, deleted:


https://github.com/user-attachments/assets/62aeb0f5-9908-411c-ac99-e8841f7ec1c3

With real data returned from the endpoint:

<img width="368" alt="SCR-20241004-jepb"
src="https://github.com/user-attachments/assets/d6b1c422-b78b-468f-961c-6b693336a388">


https://github.com/user-attachments/assets/b77b33e2-2842-4a58-8c0a-bf25d2d93be7




closes #77812
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michellewzhang michellewzhang

Labels
enhancement
Projects
Feature Flags
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(flags): add flag series to event graph getsentry/sentry
2 participants
@cmanallen @michellewzhang