Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix cohere API change #3549

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

BYK
Copy link
Member

@BYK BYK commented Sep 19, 2024

No description provided.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.53%. Comparing base (4f6ccc4) to head (2bd9188).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3549      +/-   ##
==========================================
+ Coverage   84.51%   84.53%   +0.01%     
==========================================
  Files         133      133              
  Lines       13833    13837       +4     
  Branches     2927     2927              
==========================================
+ Hits        11691    11697       +6     
  Misses       1415     1415              
+ Partials      727      725       -2     
Files with missing lines Coverage Δ
sentry_sdk/integrations/cohere.py 79.33% <100.00%> (+0.70%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BYK!

@sentrivana sentrivana added the Trigger: tests using secrets PR code is safe; run CI label Sep 20, 2024
@sentrivana sentrivana merged commit 49dd64d into getsentry:master Sep 20, 2024
125 of 127 checks passed
@BYK BYK deleted the byk/tests/fix-cohere branch September 20, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger: tests using secrets PR code is safe; run CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants