Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope.RequestBody empty while being set to event.Data in fasthttp/fiber integration #801

Open
ribice opened this issue Mar 29, 2024 · 0 comments

Comments

@ribice
Copy link
Collaborator

ribice commented Mar 29, 2024

I was debugging why fasthttp and fiber integration invoke SetRequest and then SetRequestBody immediately after, even though SetRequest sets the requestBody (same as SetRequestBody).

The issue is that for these two integrations, the Body has to be copied. Since the requestBody is lazily read (when Body is read), for these two integrations it never happens because we copied the Body and that copied Body is never read.

@ribice ribice changed the title scope.RequestBody empty while being set to event.Data scope.RequestBody empty while being set to event.Data in fasthttp/fiber integration Mar 29, 2024
@ribice ribice self-assigned this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant