Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard-code deprecated feature flags #4033

Open
3 tasks
jjbayer opened this issue Sep 13, 2024 · 0 comments
Open
3 tasks

Hard-code deprecated feature flags #4033

jjbayer opened this issue Sep 13, 2024 · 0 comments
Labels
filler Requires little effort to resolve. Ready to be picked up anytime. maintenance Tasks with this label generally have a lower priority and due date onboarding

Comments

@jjbayer
Copy link
Member

jjbayer commented Sep 13, 2024 •
edited
Loading

From Notion:

We want to avoid configuring flags in Sentry just because we need them in external Relays. Rather we want to hardcode the values in the internal Relays.

This ensures that external relays's behavior matches internal ones, and makes it unnecessary to keep feature flags around on sentry.

  • Add skip_deserializing to deprecated feature flags, serialize a default
  • [optional]: Stop renaming to Deprecated*
  • Clean up the list (most feature flags have been deprecated >1y ago)
@olksdr olksdr added filler Requires little effort to resolve. Ready to be picked up anytime. maintenance Tasks with this label generally have a lower priority and due date onboarding labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
filler Requires little effort to resolve. Ready to be picked up anytime. maintenance Tasks with this label generally have a lower priority and due date onboarding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jjbayer @olksdr