Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening a draft and a finalized form with a big csv attachment got slower #6407

Open
dbemke opened this issue Sep 10, 2024 · 2 comments
Open
Milestone

Comments

@dbemke
Copy link

dbemke commented Sep 10, 2024

ODK Collect version

the store version 2024.2.4, the master version f38ba7e

Android version

10, 14

Device used

Redmi 9T, Pixel 7a

Problem description

Opening a draft and a finalized form with a big csv attachment got slower. On Adroid 10 (Redmi 9t) opening a draft/finalized of Kobo test form takes ~10 seconds or more (in some cases ~15 seconds + black screen). On Android 14 it also takes a bit more time (but less than Android 10)
On the store version 2024.2.4 opening a draft of the form on Android 10 takes ~5 seconds

Steps to reproduce the problem

  1. Create a draft of kobo test form.
    Kobo_Test.xlsx

  2. Create a finalized form.

  3. Open the draft.

  4. Open the finalized form.
    places.csv

XRecorder_10092024_130131.mp4
@lognaturel
Copy link
Member

This may need to be filed as a separate issue but I also believe that many queries over Entity Lists will be slower as well. For example:

  • expressions with and like city=${city} and age=${age}
  • expressions with < or > like age > 18
  • expressions with idempotent function calls like starts-with(${fname}, ${start})

We should maintain or improve their performance for the release. @getodk/testers could you please do some checks on this? Let me know if you need help building forms.

@WKobus
Copy link

WKobus commented Sep 18, 2024

@lognaturel I've checked forms with listed expressions and those are slower, I filed a separate issue for this - #6422

@lognaturel lognaturel added this to the v2024.3 milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: not ready
Development

No branches or pull requests

3 participants