-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] centralise download method in one place #522
Comments
Can I work on this @ansmonjol |
Absolutely @alceil |
@ansmonjol I bit confused on how to setup the lago front on my machine locally. Didnt see anything about it in the docs either. Can you point me to resources or just tell me how i can setup the project locally? |
Hi @alceil, are you still working on this issue? If not, @ansmonjol can you assign this issue to me? |
Hey @aditipatelpro Im not working on it since i was not able to deploy it locally . @ansmonjol you can assign it to @aditipatelpro |
@aditipatelpro let me know if I can help with anything. If you don't work on this I'll remove the assignment |
Hi @ansmonjol, sorry to keep you waiting. I do not have the bandwidth to work on this currently. I have unassigned myself from this issue. |
Hi @ansmonjol, can I work on this? |
Hi @ansmonjol , I have fixed this on my local machine. Since it's done in the main Lago repo, should I create a PR there? |
Downloading an invoice is an action available multiple times in the app. Probably since this ticket have been created we're also allowed to download other type of documents.
The download logic have been duplicated but should be centralised at some point.
This ticket aims to refactor our codebase to have only one download logic written, called by every components / pages the needs it.
The text was updated successfully, but these errors were encountered: