Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] centralise download method in one place #522

Open
ansmonjol opened this issue Oct 31, 2022 · 10 comments
Open

[CHORE] centralise download method in one place #522

ansmonjol opened this issue Oct 31, 2022 · 10 comments

Comments

@ansmonjol
Copy link
Collaborator

Downloading an invoice is an action available multiple times in the app. Probably since this ticket have been created we're also allowed to download other type of documents.

The download logic have been duplicated but should be centralised at some point.

This ticket aims to refactor our codebase to have only one download logic written, called by every components / pages the needs it.

@alceil
Copy link

alceil commented Sep 7, 2023

Can I work on this @ansmonjol

@ansmonjol
Copy link
Collaborator Author

Absolutely @alceil

@alceil
Copy link

alceil commented Sep 9, 2023

@ansmonjol I bit confused on how to setup the lago front on my machine locally. Didnt see anything about it in the docs either. Can you point me to resources or just tell me how i can setup the project locally?

@ansmonjol
Copy link
Collaborator Author

@alceil you can follow the steps here

Once done, you should have all local services running in Docker.
Then you can update your code in the front folder on your machine and check the app running at app.lago.dev (default, can be changed)

@aditipatelpro
Copy link

Hi @alceil, are you still working on this issue? If not, @ansmonjol can you assign this issue to me?
I am interested in working on this.

@alceil
Copy link

alceil commented Sep 24, 2023

Hey @aditipatelpro Im not working on it since i was not able to deploy it locally . @ansmonjol you can assign it to @aditipatelpro

@ansmonjol
Copy link
Collaborator Author

@aditipatelpro let me know if I can help with anything.

If you don't work on this I'll remove the assignment

@aditipatelpro aditipatelpro removed their assignment Nov 29, 2023
@aditipatelpro
Copy link

Hi @ansmonjol, sorry to keep you waiting. I do not have the bandwidth to work on this currently. I have unassigned myself from this issue.

@haribhandari07
Copy link

haribhandari07 commented Dec 18, 2023

Hi @ansmonjol, can I work on this?

@haribhandari07
Copy link

Hi @ansmonjol, can I work on this?

Hi @ansmonjol , I have fixed this on my local machine. Since it's done in the main Lago repo, should I create a PR there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants