Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix use of declarations after nested rules (deprecated in Sass 1.77.7) #1060

Open
markdumay opened this issue Jul 31, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@markdumay
Copy link
Collaborator

Describe the bug

When using Dart Sass 1.77.7 or later, Hugo displays several deprecation warnings about the use of declarations after nested rules.

To reproduce

  1. Install Dart Sass 1.77.7 or later
  2. Set transpiler = "dartsass" in [main.build] of params.toml
  3. Run hugo

Log file

WARN  Dart Sass: file:///[...]/gethinode/hinode/_vendor/github.com/twbs/bootstrap/scss/_reboot.scss:502:2: Sass's behavior for declarations that appear after nested rules will be changing to match the behavior specified by CSS in an upcoming version. To keep the existing behavior, move the declaration above the nested rule. To opt into the new behavior, wrap the declaration in `& {}`.

Host environment

  • Hinode version: [v0.24.23]

Hugo environment

hugo v0.129.0+extended darwin/arm64 BuildDate=2024-07-17T13:29:16Z VendorInfo=brew
GOOS="darwin"
GOARCH="arm64"
GOVERSION="go1.22.5"
github.com/sass/libsass="3.6.5"
github.com/webmproject/libwebp="v1.3.2"
github.com/sass/dart-sass/protocol="2.7.1"
github.com/sass/dart-sass/compiler="1.77.8"
github.com/sass/dart-sass/implementation="1.77.8"

Additional context

The issue has been fixed in twbs/bootstrap#40623 all will be released in Bootstrap v5.3.4.

@markdumay markdumay added the bug Something isn't working label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant