Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking outside the modal should close it #168

Open
rolznz opened this issue Dec 28, 2023 · 5 comments
Open

Clicking outside the modal should close it #168

rolznz opened this issue Dec 28, 2023 · 5 comments
Labels
good first issue Good for newcomers

Comments

@rolznz
Copy link
Collaborator

rolznz commented Dec 28, 2023

Also maybe pressing escape too (for desktop)

@rolznz rolznz added the good first issue Good for newcomers label Dec 28, 2023
@ShamsudinBakaev
Copy link

ShamsudinBakaev commented Dec 28, 2023

I want to solve this problem. Are you still making decisions?

@rolznz
Copy link
Collaborator Author

rolznz commented Dec 28, 2023

Hi @ShamsudinBakaev I think it's ready to be worked on. Please go ahead! 🚀

@ekzyis
Copy link

ekzyis commented Dec 28, 2023

Would be nice if you implement this as an option. So instead of always closing the modal if clicked outside now, access to the onBlur (or similar) callback would be ideal. There might be use cases where you don't want the modal to get closed if clicked outside.

For example, sometimes a modal should stay open to prevent accidental closes. Not sure if this is one of such modals but still something to consider when implementing this imo.

@ShamsudinBakaev
Copy link

Where can i find instructions for installing the project?

@ekzyis
Copy link

ekzyis commented Dec 28, 2023

Where can i find instructions for installing the project?

I believe you're looking for this section in the README

kimdanielarthur-cowlabs added a commit to kimdanielarthur-cowlabs/bitcoin-connect that referenced this issue May 6, 2024
rolznz added a commit that referenced this issue May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants