Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor internal dictionaries module #35

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Refactor internal dictionaries module #35

merged 1 commit into from
Mar 25, 2024

Conversation

gerlero
Copy link
Owner

@gerlero gerlero commented Mar 25, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.13861% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 89.02%. Comparing base (1e987de) to head (27510f8).

❗ Current head 27510f8 differs from pull request most recent head f904a4b. Consider uploading reports for the commit f904a4b to get more accurate results

Files Patch % Lines
foamlib/_dictionaries/_serialization.py 79.36% 13 Missing ⚠️
foamlib/_dictionaries/__init__.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   89.13%   89.02%   -0.11%     
==========================================
  Files           4        7       +3     
  Lines         552      565      +13     
==========================================
+ Hits          492      503      +11     
- Misses         60       62       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gerlero gerlero merged commit 4cb2313 into main Mar 25, 2024
16 checks passed
@gerlero gerlero deleted the dictionaries branch March 25, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants