-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unnecessary pillow import by using image size from CDN endpoint #218
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 67.15% 66.46% -0.69%
==========================================
Files 43 43
Lines 1985 2016 +31
Branches 355 362 +7
==========================================
+ Hits 1333 1340 +7
- Misses 567 593 +26
+ Partials 85 83 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@gounux je me suis permis de merger main pour checker que mon fix des flaky tests fonctionne 🤞 |
Quality Gate passedIssues Measures |
kikou @Guts, à mes yeux c'est prêt pour review, avec les derniers ajouts:
|
à l'avenir ça mériterait un petit coup de refactoring, SonarLint me souffle dans l'oreillette que la complexité de la fonction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allez, go, on verra pour itérer plus tard pour le refacto/optim surtout que tu es allergique aux docstrings xD !
Je me soigne ... |
Si t'es sur VS Code, y'a l'extension autodocstring qui fait la structure automatique avec la config qui va bien dans le projet. |
No description provided.