selection tab title is misleading ?

[landryb]

when testing, @stous found it confusing that a graphical (point/line/polygon) selection tab title was 'Selection', since no entries are actually selected in the list. (shows 2 objets (0 sélectionnés))

adding to this, in the preferences tab, there are 'default' (translated as 'Liste') and 'selected' (translated as 'Sélection', cf https://github.com/georchestra/mapstore2-cadastrapp/blob/master/assets/translations/data.fr-FR.json#L84) - i'm not sure 'Selection X' is the best word to use .. should we reuse Liste there ? 'Résultat de recherche' is too large. Or it should be 'Point X'/'Line X'/'Polygon X' (with translations !) so that the user knows which tab matches a 'graphical selection' ?

this is discussed a bit in #93, and that also shows that 'Selection' isnt a translated string, which might be an issue too (in french it would be Sélection or something better) ? the various strings in

mapstore2-cadastrapp/js/extension/epics/search.js

Lines 38 to 58 in 2273380

	function getTitle(searchType, rawParams) {
	switch (searchType) {
	case SEARCH_TYPES.REFERENCE:
	return rawParams?.commune?.label;
	case SEARCH_TYPES.ADDRESS:
	return rawParams?.commune?.label;
	case SEARCH_TYPES.LOT:
	return "Lot";
	case SEARCH_TYPES.ID:
	return "Id(s)";
	case SEARCH_TYPES.OWNER_ID:
	return rawParams?.commune?.label;
	case SEARCH_TYPES.COMPTE_COMMUNAL:
	return rawParams?.comptecommunal;
	case SEARCH_TYPES.OWNER_LOT:
	return "By file";
	default:
	return null;
	}
	}

arent translated either, and i havent found where 'Selection' comes from.

@MaelREBOUX @catmorales i'm sure you'll have ideas on this.....

[MaelREBOUX]

Hummm.... not easy.

Let's see :

• the Selection 1 and Selection 2 tbas ar created by clicking on the map
• the Bruz (350047) is created by searching by plot
• the Lot is created by typing a plot id

I suggest we could manage only 2 kinds of events : Selection / Search ?
Numbered as said in #93

[landryb]

but 'selection' is misleading here i think since there's a "second selection" to do in the list, so it should rather be 'point/line X' ?

[MaelREBOUX]

it should rather be 'point/line X'

No because your list selection could be done by the 3 geometric methods. I think dicriminate by selection / search method + numbered tabs is an acceptable way. Not ?