Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using sqlalchemy > 2 #1661

Open
ricardogsilva opened this issue May 15, 2024 · 2 comments
Open

Allow using sqlalchemy > 2 #1661

ricardogsilva opened this issue May 15, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ricardogsilva
Copy link
Member

Now that pygeofilter supports sqlalchemy v2, and with the changes merged in #1520, it seems pygeoapi can now lift the current restriction on using sqlalchemy<2, as seen in:

SQLAlchemy<2.0.0

This is related to #1123, but I am not able to re-open it - feel free to close this and re-open that if appropriate.

@ricardogsilva ricardogsilva added the enhancement New feature or request label May 15, 2024
@tomkralidis
Copy link
Member

cc @kalxas

@ricardogsilva as discussed a couple of weeks ago, looks like SQLAlchemy is still at 1.x on jammy. We'll need to monitor accordingly and update once we have some updates from upstream.

@ricardogsilva
Copy link
Member Author

ricardogsilva commented Jul 25, 2024

@tomkralidis @kalxas

Just a small nitpick, current Ubuntu LTS is now 24.04 (Noble Numbat) - but your point is still valid, the python3-sqlalchemy package is still at version 1.4.50 as per:

https://packages.ubuntu.com/noble/python3-sqlalchemy

According to sqlalchemy docs, v1.4 is compatible with version 2 and in #1520 I had already fixed existing sqlalchemy transition to v2 warnings in the codebase.

This to say that I think we are now in a position where it is possible to simply remove the sqlalchemy<v2 pin in our requirements files and things should work OK both on Ubuntu LTS, as per RFC2 and would also allow other installs to move forward with using sqlalchemy v2+.

When I find some time I will check whether everything works OK with the pin removed, most likely by trying to run the test suite inside some ubuntu:24.04 container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants