Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline email functionality #417

Open
justb4 opened this issue Jan 5, 2022 · 0 comments
Open

Streamline email functionality #417

justb4 opened this issue Jan 5, 2022 · 0 comments

Comments

@justb4
Copy link
Member

justb4 commented Jan 5, 2022

Is your feature request related to a problem? Please describe.
Email is sent in two places: in notifications.py and in util.py (send_email function).
Via #416 some fixes were made in notifications.py to cope with various email configurations TLS, no Auth etc, for both Docker and regular installs. This is for Resource notification only. All other email (lost password, status summary, ..) is still sent
with util.py-send_email.

Describe the solution you'd like
Provide a single send_email() function for all email-sending cases. Best is to take util.py-send_email and extend with the implementation in notifications.py. Make the function robust for config errors. May still be lean/silently fail, on login() failure as that is optional and may break existing installs.

Describe alternatives you've considered
We could discard SMTPLib and use a higher level email lib. But that also introduces an additional dependency, plus may break existing installations.

Additional context
N.A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant