Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implicite globals #23

Open
kof opened this issue Jun 4, 2011 · 4 comments
Open

implicite globals #23

kof opened this issue Jun 4, 2011 · 4 comments
Assignees

Comments

@kof
Copy link

kof commented Jun 4, 2011

I didn't tested your lib, just looked over it - everywhere global variables, defined implicitely .... example

https://github.com/geometria-lab/Beseda/blob/master/server/lib/server.js#L15

it sucks!

@shumkov
Copy link
Contributor

shumkov commented Jun 5, 2011

It's globaly only for this module. For use gobal variables in nodejs you must do global.variable = 'test'

@ghost ghost assigned shumkov Jun 5, 2011
@kof
Copy link
Author

kof commented Jun 6, 2011

just tested, its truth. I left the changelog entry about this mode is the default one now.

Nevertheless this is done is to avoid global namespace pollution and memory leaks, not to be used at this way. This will also cause errors in strict mode, so its a bad style.

@shumkov
Copy link
Contributor

shumkov commented Jun 6, 2011

But I agree, it's it sucks! :)

@shumkov
Copy link
Contributor

shumkov commented Jun 6, 2011

Thank you for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants