Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: GeoJSON で marker-symbol を指定してもアイコンが表示されない #320

Merged
merged 4 commits into from
Dec 13, 2022
Merged

Fix: GeoJSON で marker-symbol を指定してもアイコンが表示されない #320

merged 4 commits into from
Dec 13, 2022

Conversation

naogify
Copy link
Member

@naogify naogify commented Dec 9, 2022 •
edited
Loading

Close #319 #293

現状、geojson のプロパティで、marker-symbol を指定しても、Embed API で、-11 と -15 を追加するので、
マーカーが表示されなかったので、

marker-symbol を指定時は、以下の処理をする様に修正しました。

  • circle を非表示にする
  • サフィックスは無しにしてユーザーが指定したアイコンをそのまま表示

@naogify naogify changed the title remove -11, -15 suffix, and hide circle when marker-symbol specified Remove -11, -15 suffix, and hide circle when marker-symbol specified Dec 9, 2022
@naogify naogify marked this pull request as ready for review December 9, 2022 08:47
@naogify naogify changed the title Remove -11, -15 suffix, and hide circle when marker-symbol specified Fix: GeoJSON で marker-symbol を指定してもアイコンが表示されない Dec 9, 2022
champierre
champierre approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@champierre champierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naogify
Copy link
Member Author

naogify commented Dec 13, 2022

@champierre
ありがとうございます! マージします。

@naogify naogify merged commit 61a58d5 into master Dec 13, 2022
@naogify naogify deleted the geojson-symbol-marker branch December 13, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@champierre champierre champierre approved these changes

@kamataryo kamataryo Awaiting requested review from kamataryo

@keichan34 keichan34 Awaiting requested review from keichan34

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

marker-symbol の -11, -15 の処理を削除
2 participants
@naogify @champierre