Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored tags and hoisted developers in mod info #59

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hiimjustin000
Copy link
Contributor

  • Colored tags in the mod's description tab
  • Colored tags in the mod's changelog tab
  • Hoisted mod owner in the full developer list

@qimiko
Copy link
Contributor

qimiko commented Jul 8, 2024

this pull request has made me discover an issue with the markdown renderer. so this won't work anymore on the latest commit, but that's probably a good thing.

you are welcome to change out the libraries if svelte-markdown doesn't offer enough flexibility. considering you have access to the marked options, i think there's more than enough room to add a proper color tag parser lol

@hiimjustin000
Copy link
Contributor Author

The reason for the weird implementation of this feature is due to how svelte-markdown handles HTML. To put it simply, it can't, without duplicating elements. I've tried more intuitive ways multiple times, only to fall short every single time. I can't go any other way.

Looks like the XSS vulnerabilities have been patched by the latest commit, and due to the way I implemented it, it still works. Any other way guarantees the duplication. I do not know the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants