New Release v1.28.0 - #minor #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this PR is merged on develop those test are often not passing because it seems that when trying to open the menu settings a second time it opened the give feedback view somehow.
Try solve test flakiness introduced by #922
The roadmap was outdated and we don't want to manage the roadmap here anymore. Same for ADR we will put our ADR in confluence in the future.
Updated readme
PB-497: Add GPX on 3D map
When resizing the window from small to big the elevation profile was not re-render properly. See https://www.chartjs.org/docs/master/configuration/responsive.html#important-note
PB-660: Fix elevation profile resize
Some attribution are not link and cannot be clicked. In this case they should be selectable. Previously all attributions were not selectable and they all had the pointer cursor.
PB-647: Fix CSS non link attribution
The key press is only effective when the map is in focus or the time slider button or the timeslisder play button. This ensure that the key press doesn't interfere with other UI component like the search input field for example.
PB-643: Implement left/right key press to move time slider
Passing run #2610 ↗︎
Details:
Review all test suite changes for PR #931 ↗︎ |
|||||||||||||||
pakb
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link