PB-562 : do not force drawing module's style onto external KMLs #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #2405 ↗︎
Details:
Review all test suite changes for PR #884 ↗︎ |
|||||||||||||||
forcing this resulted in KMLs being misrepresented, with colors not matching what was in the KML's data
the style of KML loaded from the import file tool is the default style OpenLayers applies to KMLs, and not the one we have been adding in our DrawingModule. Tests here for print were made on the assumption that we are dealing with KMLs coming out of our DrawingModule, hence this change
pakb
force-pushed
the
bug_PB-562_wrong_external_kml_style
branch
from
504e01f
to
b5dfb2f
Compare
ltshb
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forcing this resulted in KMLs being misrepresented, with colors not matching what was in the KML's data
Test link