Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-494: Add address bar on 3D map #880

Merged
merged 10 commits into from
Jun 13, 2024
Merged

PB-494: Add address bar on 3D map #880

merged 10 commits into from
Jun 13, 2024

Conversation

ismailsunni
Copy link
Contributor

@ismailsunni ismailsunni commented Jun 6, 2024 •
edited by github-actions bot
Loading

@github-actions github-actions bot added the bug Something isn't working label Jun 6, 2024
@ismailsunni ismailsunni marked this pull request as ready for review June 6, 2024 00:57
@ismailsunni ismailsunni requested review from ltshb and pakb June 6, 2024 00:57
@cypress Cypress
Copy link

cypress bot commented Jun 6, 2024 •
edited
Loading

Passing run #2523 ↗︎

0 208 20 0 Flakiness 0

Details:

PB-494: Fix failing test (blank white bottom bar on mobile).
Project: web-mapviewer Commit: 0c6885d241
Status: Passed Duration: 06:40 💡
Started: Jun 13, 2024 8:17 AM Ended: Jun 13, 2024 8:23 AM

Review all test suite changes for PR #880 ↗︎

@ismailsunni ismailsunni force-pushed the fix-494-3d-address-bar branch 3 times, most recently from b4511f2 to 7e03924 Compare June 6, 2024 09:59
@ismailsunni ismailsunni requested a review from pakb June 10, 2024 10:29
@ismailsunni ismailsunni force-pushed the fix-494-3d-address-bar branch 4 times, most recently from e23ce81 to 4de1514 Compare June 11, 2024 07:42
pakb
pakb approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, maybe a rebase would fix tests because it doesn't seem related to what you changed...

@ismailsunni
Copy link
Contributor Author

hi @pakb I have done many rebasing for this PR, but unfortunately, no luck. And as you said, it seems unrelated to my changes.

@ismailsunni ismailsunni force-pushed the fix-494-3d-address-bar branch 2 times, most recently from 5c2e474 to 1190211 Compare June 12, 2024 07:43
@ismailsunni ismailsunni merged commit 15d501f into develop Jun 13, 2024
6 checks passed
@ismailsunni ismailsunni deleted the fix-494-3d-address-bar branch June 13, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakb pakb pakb approved these changes

@ltshb ltshb Awaiting requested review from ltshb

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismailsunni @pakb