BGDIINF_SB-3061 : keep where the camera is looking at when going back 2D #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansmannj
reviewed
Aug 23, 2023
There was a problem hiding this comment.
Nice!
Probably an edge case:
In 3D, when tilting the camera to a very low angle, it is possible that the camera position gets below the terrain and the user sees the "sky".
Tilting back to a more "normal" steeper angle, the camera position does not correspond with the initial position but can be completely off (i.e. even outside of CH).
pakb
force-pushed
the
feat_BGDIINF_SB-3061_keep_camera_target_when_going_2D
branch
from
47b2b1b
to
4b67aef
Compare
and not where the camera is positioned, otherwise the view (top-down at the position of the camera) doesn't correspond at all with what the user was seeing in 3D
pakb
force-pushed
the
feat_BGDIINF_SB-3061_keep_camera_target_when_going_2D
branch
from
4b67aef
to
756bd35
Compare
pakb
deleted the
feat_BGDIINF_SB-3061_keep_camera_target_when_going_2D
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and not where the camera is positioned, otherwise the view (top-down at the position of the camera) doesn't correspond at all with what the user was seeing in 3D
Test link