Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGDIINF_SB-3060 : persistence of selected feature when going 3D #440

Merged

Conversation

pakb
Copy link
Contributor

@pakb pakb commented Aug 21, 2023

and also when going from 3D to 2D, the selected features stay selected, and the popup now shows directly at OL or Cesium startup

Test link

@pakb pakb force-pushed the feat_BGDIINF_SB-3060_persist_selected_feature_when_going_3D branch from 20d077a to def3df3 Compare August 21, 2023 15:32
and also when going from 3D to 2D, the selected features stay selected, and the popup now shows directly at OL or Cesium startup
@pakb pakb force-pushed the feat_BGDIINF_SB-3060_persist_selected_feature_when_going_3D branch from 5e0400f to ad9a9bb Compare August 21, 2023 15:36
@pakb pakb requested review from hansmannj and ltshb August 21, 2023 17:41
@ltshb
Copy link
Contributor

ltshb commented Aug 22, 2023

When using the infox in the footer and switching back and forth to the 2D/3D view, the infobox is then empty. You need to toggle it back to the infobox overlay and back to header to have the data.

@pakb
Copy link
Contributor Author

pakb commented Aug 22, 2023

When using the infox in the footer and switching back and forth to the 2D/3D view, the infobox is then empty. You need to toggle it back to the infobox overlay and back to header to have the data.

thanks for spotting it! should be fixed with the latest commit (height of the infobox container wasn't recalculated...)

when the feature details is in the footer, the content height wasn't recalculated on mapping framework switches, rendering the content with a height of zero.
@pakb pakb force-pushed the feat_BGDIINF_SB-3060_persist_selected_feature_when_going_3D branch from 5077582 to c54e741 Compare August 23, 2023 06:06
Copy link
Member

@hansmannj hansmannj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, from what I can tell. And now switching back to 2d also works as expected, thanks! 👍

@pakb pakb merged commit 26a996a into develop Aug 23, 2023
3 checks passed
@pakb pakb deleted the feat_BGDIINF_SB-3060_persist_selected_feature_when_going_3D branch August 23, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants