BGDIINF_SB-2981: Add cesium-compass widget #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
force-pushed
the
feat-BGDIINF_SB-2981-add-cesium-compass
branch
from
1489d93
to
cc2e6ba
Compare
pakb
reviewed
Jul 10, 2023
There was a problem hiding this comment.
looking good so far, I'll think about this "tool box" we discussed last time
it works also not too bad being at the bottom of the view
we should maybe hide it as soon as we are in mobile (there's a flag somewhere in ui.store.js that set this), and maybe even before (for tablets too) as I've not had the best experience with this compass on my iPhone.
The panning is correctly detected but then it never ends (touchend or pointerup is never caught)
|
@pakb Done: the widget is now only displayed on desktop |
fredj
force-pushed
the
feat-BGDIINF_SB-2981-add-cesium-compass
branch
from
067344f
to
eaa9c0a
Compare
pakb
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link