Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGDIINF_SB-2018: catalogNodes parameter support #416

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

ltkum
Copy link
Contributor

@ltkum ltkum commented Jun 27, 2023

Issue : When specifying a catalogNodes in the URL, it didn't open the
corresponding catalog Nodes.

Fix : Created a type of URL parameter which is not bi-directional
(modifying the URL will modify the store, modifying the store won't
touch the URL), and added watchers and actions to track and make use of
it

Test link

@ltkum ltkum requested a review from pakb June 27, 2023 07:43
@ltkum ltkum force-pushed the feat-BGDIINF_SB-2018-add-catalogNodes-URL-param-support branch from e4c1c3c to 0f85891 Compare June 27, 2023 08:39
@ltkum ltkum force-pushed the feat-BGDIINF_SB-2018-add-catalogNodes-URL-param-support branch 3 times, most recently from 8b50891 to ce787c5 Compare July 3, 2023 05:01
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to clean your git log 😉
a good help, if you're as me a bit too visual to do everything through git command, is to use some GUI like GitKraken, helps a lot to keep things clean

@ltkum ltkum force-pushed the feat-BGDIINF_SB-2018-add-catalogNodes-URL-param-support branch from ce787c5 to 4c7b031 Compare July 4, 2023 02:41
@ltkum ltkum requested a review from pakb July 4, 2023 07:32
@ltkum ltkum force-pushed the feat-BGDIINF_SB-2018-add-catalogNodes-URL-param-support branch 3 times, most recently from b53e7b3 to d580299 Compare July 6, 2023 07:14
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve (or remove) all remaining TODOs ?

@ltkum ltkum force-pushed the feat-BGDIINF_SB-2018-add-catalogNodes-URL-param-support branch from d580299 to 51c5c0d Compare July 11, 2023 07:12
@ltkum ltkum requested a review from pakb July 11, 2023 07:12
src/router/storeSync/storeSync.config.js Outdated Show resolved Hide resolved
tests/e2e-cypress/integration/topics.cy.js Outdated Show resolved Hide resolved
@ltkum ltkum force-pushed the feat-BGDIINF_SB-2018-add-catalogNodes-URL-param-support branch 2 times, most recently from 6d44f9e to ac13ec5 Compare July 13, 2023 09:33
@ltkum ltkum requested a review from pakb July 13, 2023 09:34
@ltkum ltkum force-pushed the feat-BGDIINF_SB-2018-add-catalogNodes-URL-param-support branch from ac13ec5 to c4ff484 Compare July 13, 2023 09:35
Issue : When specifying a catalogNodes in the URL, it didn't open the
corresponding catalog Nodes.

Fix : Created a type of URL parameter which is not bi-directional
(modifying the URL will modify the store, modifying the store won't
touch the URL), and added watchers and actions to track and make use of
it
cypress tests added for the catalogNodes functionality

formatting and linting after rebase

removing todos

removing duplicate

formatting
@ltkum ltkum force-pushed the feat-BGDIINF_SB-2018-add-catalogNodes-URL-param-support branch from c4ff484 to 3171e00 Compare July 13, 2023 16:17
@pakb pakb merged commit 21ea4cc into develop Jul 14, 2023
3 checks passed
@pakb pakb deleted the feat-BGDIINF_SB-2018-add-catalogNodes-URL-param-support branch July 14, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants