-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BGDIINF_SB-2018: catalogNodes parameter support #416
BGDIINF_SB-2018: catalogNodes parameter support #416
Conversation
e4c1c3c
to
0f85891
Compare
8b50891
to
ce787c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to clean your git log 😉
a good help, if you're as me a bit too visual to do everything through git command, is to use some GUI like GitKraken, helps a lot to keep things clean
ce787c5
to
4c7b031
Compare
b53e7b3
to
d580299
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you resolve (or remove) all remaining TODOs ?
d580299
to
51c5c0d
Compare
6d44f9e
to
ac13ec5
Compare
ac13ec5
to
c4ff484
Compare
Issue : When specifying a catalogNodes in the URL, it didn't open the corresponding catalog Nodes. Fix : Created a type of URL parameter which is not bi-directional (modifying the URL will modify the store, modifying the store won't touch the URL), and added watchers and actions to track and make use of it
cypress tests added for the catalogNodes functionality formatting and linting after rebase removing todos removing duplicate formatting
c4ff484
to
3171e00
Compare
Issue : When specifying a catalogNodes in the URL, it didn't open the
corresponding catalog Nodes.
Fix : Created a type of URL parameter which is not bi-directional
(modifying the URL will modify the store, modifying the store won't
touch the URL), and added watchers and actions to track and make use of
it
Test link