Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-1046: Fallback to default icon set if not found #1097

Merged
merged 5 commits into from
Oct 17, 2024
Merged

PB-1046: Fallback to default icon set if not found #1097

merged 5 commits into from
Oct 17, 2024
+27 −6

Conversation

ismailsunni
Copy link
Contributor

@ismailsunni ismailsunni commented Oct 16, 2024 •
edited
Loading

@cypress Cypress
Copy link

cypress bot commented Oct 16, 2024 •
edited
Loading

web-mapviewer    Run #3589

Run Properties:  status check passed Passed #3589  •  git commit 7dcdf4dae8: PB-1046: Update dispatcher to the one call it.
Project web-mapviewer
Run status status check passed Passed #3589
Run duration 04m 01s
Commit git commit 7dcdf4dae8: PB-1046: Update dispatcher to the one call it.
Committer Ismail Sunni
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 211

@ismailsunni ismailsunni changed the title Pb 1046 babs icon PB-1046: Fallback to default icon set if not found Oct 16, 2024
@ismailsunni ismailsunni marked this pull request as ready for review October 16, 2024 07:08
ltshb
ltshb approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@ltshb ltshb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good just a minor issue to changes before merging.

src/modules/drawing/DrawingModule.vue Outdated
iconSetName: iconArgs.set,
}),
],
dispatcher: 'kmlUtils.js',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong dispatcher use the one on top of the file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this one is dispatched from kmlUtils.js as a callback. I follow the same approach as in https://github.com/geoadmin/web-mapviewer/blob/develop/src/modules/map/components/openlayers/OpenLayersKMLLayer.vue#L86-L112

or should I change that one too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and no, the callback is defined outside of kmlUtils.js and the caller is the file that call the helper function in kmlUtils.js.
I think for clarity it might make more sense to keep the file that contains the definition as dispatcher. This dispatcher can be useful for debugging so you will first look in kmlUtils.js and it will be then hard to find the dispatch in this file.

@ismailsunni ismailsunni merged commit 9c11e93 into develop Oct 17, 2024
6 checks passed
@ismailsunni ismailsunni deleted the pb-1046-babs-icon branch October 17, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltshb ltshb ltshb approved these changes

@ltkum ltkum Awaiting requested review from ltkum

@pakb pakb Awaiting requested review from pakb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismailsunni @ltshb