Enforced triple eq in condition statements #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakb
reviewed
Oct 7, 2024
web-mapviewer
|
||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Run status |
|
| Run duration | 05m 13s |
| Commit |
|
| Committer | Stefan Heinemann |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
211
|
The rule enforces the use of === in every situation
The layer store had a comparison that didn't work anymore due to the introduction of the eqeqeq rule. Need to check for undefined *and* null separately now.
schtibe
force-pushed
the
feat-eqeqeq-rule-in-eslint
branch
from
1c36744
to
a7166cb
Compare
pakb
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the eslint rule eqeqeq which enforces the use of triple equals (
===and!=).Test link