Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression of PR885 - Flight tracks are unexpectedly clampedToGround #1016

Closed
t0b3 opened this issue Jul 31, 2024 · 8 comments · Fixed by #1049
Closed

Regression of PR885 - Flight tracks are unexpectedly clampedToGround #1016

t0b3 opened this issue Jul 31, 2024 · 8 comments · Fixed by #1049

Comments

@t0b3
Copy link

t0b3 commented Jul 31, 2024

PR #885 introduced a regression:

  • flight tracks are unexpectedly clampedToGround

state before PR#885 == expected result
https://sys-map.dev.bgdi.ch/preview/bug_pb-562_wrong_external_kml_style/index.html#/map?sr=3857&center=802000,5970370&camera=7.204872,47.173075,1477,-5,51,&z=17&3d&bgLayer=ch.swisstopo.swisstlm3d-karte-farbe_3d&layers=KML%7C208_Weissenstein_20_07_2024.kml
image

state after PR#885 == actual result
https://sys-map.dev.bgdi.ch/preview/bug_pb-591_3d_kml_improvments/index.html#/map?sr=3857&center=802000,5970370&camera=7.204872,47.173075,1477,-5,51,&z=17&3d&bgLayer=ch.swisstopo.swisstlm3d-karte-farbe_3d&layers=KML%7C208_Weissenstein_20_07_2024.kml
image

unfortunately theese two overrides ignore existing KML settings like <altitudeMode>absolute</altitudeMode> and opacity

alphaToApply = 0.5
clampToGround = true

while clampToGround may make a lot of sense in some cases - for polylines it's not generally applicable ;-)

nb: does cesium parse altitudeMode well enough, doesn't it?

@ltshb
Copy link
Contributor

ltshb commented Aug 5, 2024

@t0b3 thanks for notifying us, we will have a look at it.

@ltshb
Copy link
Contributor

ltshb commented Aug 5, 2024

Internal ticket created at PB-865

@pakb
Copy link
Contributor

pakb commented Aug 30, 2024

Hi @t0b3 ,
could you give a try on this Test link with the file you linked above? As it is a local file, it wasn't shared with us. And I couldn't test it myself

@t0b3
Copy link
Author

t0b3 commented Aug 30, 2024

@pakb while the path is now visible in the correct altitude 👍
image
let me share those observations:

  • no terrain visible i.e. if chosen SWISSIMAGE or SWISSALTI3D
  • the opacity from the KML is not respected but overriden and set to 0.5

@pakb pakb closed this as completed in #1049 Sep 2, 2024
@pakb
Copy link
Contributor

pakb commented Sep 2, 2024

Will be deployed in the next couple days on map.geo.admin.ch (I still have to found out why no background was shown in 3D)

@pakb
Copy link
Contributor

pakb commented Sep 2, 2024

@t0b3 it should now be available on https://map.geo.admin.ch if you want to test it again

@pakb
Copy link
Contributor

pakb commented Sep 2, 2024

the issue with KML is a known bug in 3D, but we sadly don't have an easy fix for that, we will be working more on 3D for the next version

@t0b3
Copy link
Author

t0b3 commented Sep 2, 2024

@pakb thanks for the fix 😄 it works like a charm on PROD now (as you mentioned except for KML opacity)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants