-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression of PR885 - Flight tracks are unexpectedly clampedToGround #1016
Comments
@t0b3 thanks for notifying us, we will have a look at it. |
Internal ticket created at PB-865 |
@pakb while the path is now visible in the correct altitude 👍
|
Will be deployed in the next couple days on map.geo.admin.ch (I still have to found out why no background was shown in 3D) |
@t0b3 it should now be available on https://map.geo.admin.ch if you want to test it again |
the issue with KML is a known bug in 3D, but we sadly don't have an easy fix for that, we will be working more on 3D for the next version |
@pakb thanks for the fix 😄 it works like a charm on PROD now (as you mentioned except for KML opacity) |
PR #885 introduced a regression:
state before PR#885 == expected result
https://sys-map.dev.bgdi.ch/preview/bug_pb-562_wrong_external_kml_style/index.html#/map?sr=3857¢er=802000,5970370&camera=7.204872,47.173075,1477,-5,51,&z=17&3d&bgLayer=ch.swisstopo.swisstlm3d-karte-farbe_3d&layers=KML%7C208_Weissenstein_20_07_2024.kml
state after PR#885 == actual result
https://sys-map.dev.bgdi.ch/preview/bug_pb-591_3d_kml_improvments/index.html#/map?sr=3857¢er=802000,5970370&camera=7.204872,47.173075,1477,-5,51,&z=17&3d&bgLayer=ch.swisstopo.swisstlm3d-karte-farbe_3d&layers=KML%7C208_Weissenstein_20_07_2024.kml
unfortunately theese two overrides ignore existing KML settings like
<altitudeMode>absolute</altitudeMode> and opacity
web-mapviewer/src/modules/map/components/cesium/CesiumKMLLayer.vue
Lines 54 to 55 in 1428f4f
while clampToGround may make a lot of sense in some cases - for polylines it's not generally applicable ;-)
nb: does cesium parse
altitudeMode
well enough, doesn't it?The text was updated successfully, but these errors were encountered: