Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: add sort option #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

server: add sort option #184

wants to merge 1 commit into from

Conversation

rck
Copy link

@rck rck commented Apr 23, 2019

This adds a '--sort' to the 'server' sub-command. Currently there is
only one sort option, which is by create date. I assumed that his is
useful in general, compared to a random order, so I made this the
default.

This is slightly over engineered, but makes it easier to add additional
sorting options later. One that comes to my mind is sorting by tag (some
kind of natsort/semversort).

Signed-off-by: Roland Kammerer [email protected]

@rck
Copy link
Author

rck commented May 8, 2019

It's now 2 weeks without feedback, is there anything I can do? @jessfraz maybe?

@jessfraz
Copy link
Collaborator

ah dope can we change "create-date" to "created" and update the readme :)

so sorry for the delay this is awesome :)

This adds a '--sort' to the 'server' sub-command. Currently there is
only one sort option, which is by create date. I assumed that his is
useful in general, compared to a random order, so I made this the
default.

This is slightly over engineered, but makes it easier to add additional
sorting options later. One that comes to my mind is sorting by tag (some
kind of natsort/semversort).

Signed-off-by: Roland Kammerer <[email protected]>
@rck
Copy link
Author

rck commented Jun 11, 2019

  • changed to "created"
  • added "--sort" to README.md, and while at it, sorted "server -h" in README.md to match the actual cli output (guess new options have been appended, so it got unsorted).
  • rebased to current master

@rck
Copy link
Author

rck commented Jun 26, 2019

@jessfraz Time for another 2 weeks reminder :-). Anything else missing?

@joseluisq
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants