Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm patch differs between local version and online pull? #7

Open
monkey-jsun opened this issue Oct 1, 2022 · 2 comments
Open

llvm patch differs between local version and online pull? #7

monkey-jsun opened this issue Oct 1, 2022 · 2 comments

Comments

@monkey-jsun
Copy link

The dockerfile pulls the llvm patch from online, https://github.com/emacski/llvm-project/commit/2fd6a43c9adf6f05936e59a379de236b5d8885b6.diff

However it does not match the content stored in local patch/ directory. Maybe local version is outdated?

@genshen
Copy link
Owner

genshen commented Oct 2, 2022

The local patch file you mentioned is used for clang v13.0.0, which keeps the same with the online pull in Dockerfile (https://github.com/genshen/docker-clang-toolchain/blob/v13.0.0/Dockerfile#L20) of v13.0.0.
However, for clang v14.0.0, I haven't put a local patch into patch/ directory, which may misleading you.

(In other words, the "patch differing" you just mentioned is above local patch for clang v13 and online patch for clang v14.)

@monkey-jsun
Copy link
Author

OK. Thanks for the great work.

It is kind of bummer that we can will apply local patches during "docker build" time. Do you know if we can do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants