From 70cccb2dad101d76f152409bc2517a70376e8f0d Mon Sep 17 00:00:00 2001 From: Carlos Eduardo Cabral da Cunha Date: Tue, 2 Jul 2019 14:44:37 -0300 Subject: [PATCH 1/9] #298 adding create header labels to pages that did not have them --- app/controllers/advisement_authorizations_controller.rb | 3 ++- app/controllers/enrollment_holds_controller.rb | 1 + app/controllers/queries_controller.rb | 2 +- app/controllers/roles_controller.rb | 3 ++- .../thesis_defense_committee_participations_controller.rb | 2 +- config/locales/pt-BR.yml | 3 +++ 6 files changed, 10 insertions(+), 4 deletions(-) diff --git a/app/controllers/advisement_authorizations_controller.rb b/app/controllers/advisement_authorizations_controller.rb index e4538e88..42c415c8 100644 --- a/app/controllers/advisement_authorizations_controller.rb +++ b/app/controllers/advisement_authorizations_controller.rb @@ -5,6 +5,7 @@ class AdvisementAuthorizationsController < ApplicationController authorize_resource active_scaffold :advisement_authorization do |config| + config.create.label = :create_advisement_authorization_label config.columns = [:professor, :level] config.actions.swap :search, :field_search config.field_search.columns = [:professor, :level] @@ -17,4 +18,4 @@ class AdvisementAuthorizationsController < ApplicationController config.actions.exclude :deleted_records end record_select :per_page => 10 -end \ No newline at end of file +end diff --git a/app/controllers/enrollment_holds_controller.rb b/app/controllers/enrollment_holds_controller.rb index 6929b06e..5a100c96 100644 --- a/app/controllers/enrollment_holds_controller.rb +++ b/app/controllers/enrollment_holds_controller.rb @@ -5,6 +5,7 @@ class EnrollmentHoldsController < ApplicationController authorize_resource active_scaffold :"enrollment_hold" do |config| + config.create.label = :create_enrollment_hold_label config.columns = [:enrollment, :year, :semester, :number_of_semesters, :active] config.actions.swap :search, :field_search config.field_search.columns = [:enrollment, :active] diff --git a/app/controllers/queries_controller.rb b/app/controllers/queries_controller.rb index 23af22bf..15e775e3 100644 --- a/app/controllers/queries_controller.rb +++ b/app/controllers/queries_controller.rb @@ -5,7 +5,7 @@ class QueriesController < ApplicationController authorize_resource active_scaffold :query do |config| - + config.create.label = :create_query_label config.action_links.add 'execute', :label => "".html_safe, :page => true, diff --git a/app/controllers/roles_controller.rb b/app/controllers/roles_controller.rb index 83147c47..1ebf24cb 100644 --- a/app/controllers/roles_controller.rb +++ b/app/controllers/roles_controller.rb @@ -6,6 +6,7 @@ class RolesController < ApplicationController authorize_resource active_scaffold :role do |config| + config.create.label = :create_role_label config.list.columns = [:id, :name, :description] config.columns = [:name, :description] config.columns[:description].form_ui = :textarea @@ -14,4 +15,4 @@ class RolesController < ApplicationController config.actions.exclude :deleted_records end -end \ No newline at end of file +end diff --git a/app/controllers/thesis_defense_committee_participations_controller.rb b/app/controllers/thesis_defense_committee_participations_controller.rb index e3f2188c..a2247f40 100644 --- a/app/controllers/thesis_defense_committee_participations_controller.rb +++ b/app/controllers/thesis_defense_committee_participations_controller.rb @@ -7,7 +7,7 @@ class ThesisDefenseCommitteeParticipationsController < ApplicationController active_scaffold :"thesis_defense_committee_participation" do |config| columns = [:enrollment, :professor] - + config.create.label = :create_thesis_defense_committee_participation_label config.list.columns = columns config.create.columns = columns config.update.columns = columns diff --git a/config/locales/pt-BR.yml b/config/locales/pt-BR.yml index f4b930d4..7bd11af8 100644 --- a/config/locales/pt-BR.yml +++ b/config/locales/pt-BR.yml @@ -751,6 +751,7 @@ pt-BR: create_deferral_type_label: "Adicionar Tipo de Prorrogação" create_dismissal_label: "Adicionar Desligamento" create_dismissal_reason_label: "Adicionar Razão de Desligamento" + create_enrollment_hold_label: "Adicionar Trancamento" create_enrollment_label: "Adicionar Matrícula" create_enrollment_status_label: "Adicionar Tipo de Matrícula" create_institution_label: "Adicionar Instituição" @@ -762,8 +763,10 @@ pt-BR: create_phase_label: "Adicionar Fase" create_professor_label: "Adicionar Professor" create_professor_research_area_label: "Adicionar Área de Pesquisa do Professor" + create_query_label: "Adicionar Consulta" create_report_configuration_label: "Adicionar Configuração de Relatório" create_research_area_label: "Adicionar Área de Pesquisa" + create_role_label: "Adicionar Papel" create_scholarship_duration_label: "Adicionar Bolsa" create_scholarship_label: "Adicionar Bolsa" create_scholarship_type_label: "Adicionar Tipo de Bolsa" From 50f1f60022c57cbed9d6ed906fba3c7cc3d066b9 Mon Sep 17 00:00:00 2001 From: Carlos Eduardo Cabral da Cunha Date: Tue, 2 Jul 2019 18:39:46 -0300 Subject: [PATCH 2/9] #297 adding rspec presence tests to model Query and fixing them --- app/helpers/queries_helper.rb | 3 ++- app/models/query.rb | 3 +++ spec/models/query_spec.rb | 18 ++++++++++++++++++ 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/app/helpers/queries_helper.rb b/app/helpers/queries_helper.rb index 56271174..efbea40d 100644 --- a/app/helpers/queries_helper.rb +++ b/app/helpers/queries_helper.rb @@ -4,6 +4,7 @@ module QueriesHelper def code_mirror_text_area(column, id, type, options) + options[:required] = false block = text_area(:record, :sql_query, options) block += "