Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethexe: remove the deprecated ethers crate in favor of alloy #4197

Closed
grishasobol opened this issue Aug 28, 2024 · 0 comments · Fixed by #4316
Closed

ethexe: remove the deprecated ethers crate in favor of alloy #4197

grishasobol opened this issue Aug 28, 2024 · 0 comments · Fixed by #4316
Labels
A4-insubstantial Not too important PR C2-refactoring Refactoring proposal

Comments

@grishasobol
Copy link
Member

grishasobol commented Aug 28, 2024

File Location(s)

ethexe/signer/src/lib.rs

Proposal

Remove it here for example

// Recover the address using the signature
let ethers_sig = ethers::core::types::Signature::try_from(&signature.0[..])
.expect("failed to parse sig");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-insubstantial Not too important PR C2-refactoring Refactoring proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant