Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethexe: emitting an event for ValueClaimed when value == 0 is confusing #4179

Open
jekennedy opened this issue Aug 22, 2024 · 0 comments
Open

ethexe: emitting an event for ValueClaimed when value == 0 is confusing #4179

jekennedy opened this issue Aug 22, 2024 · 0 comments

Comments

@jekennedy
Copy link

Problem to Solve

In ethexe/contracts/src/Mirror.sol, the function valueClaimed attempts to transfer tokens to a given destination. If value == 0, no transfer happens, but the function still emits the event ValueClaimed.

Possible Solution

If value is 0, emit a different event. Like ValueClaimAttempted.

Notes

No response
@grishasobol grishasobol changed the title Emitting an event for ValueClaimed when value == 0 is confusing ethexe: emitting an event for ValueClaimed when value == 0 is confusing Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jekennedy