Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethexe: the function _retrieveValueToRouter of Mirror.sol is confusing #4178

Open
jekennedy opened this issue Aug 22, 2024 · 0 comments
Open

ethexe: the function _retrieveValueToRouter of Mirror.sol is confusing #4178

jekennedy opened this issue Aug 22, 2024 · 0 comments

Comments

@jekennedy
Copy link

File Location(s)

gear/ethexe/contracts/src/Mirror.sol

Proposal

This function does a token transfer when interacting with the Mirror contract. It transfers tokens from the caller to the Router. With this in mind, the function should be called something like:

  • _sendValueToRouter
  • _collectFeeForRouter
@grishasobol grishasobol changed the title eth.exe: the function _retrieveValueToRouter of Mirror.sol is confusing ethexe: the function _retrieveValueToRouter of Mirror.sol is confusing Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jekennedy