Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethexe: slash peer/validator in case of network request errors #4175

Open
grishasobol opened this issue Aug 21, 2024 · 1 comment
Open

ethexe: slash peer/validator in case of network request errors #4175

grishasobol opened this issue Aug 21, 2024 · 1 comment
Labels
C1-feature Feature request P2-sometimesoon Medium priority

Comments

@grishasobol
Copy link
Member

Problem to Solve

Presently processing of network request error is not considering as service execution work finish with error

let result = Self::process_network_message(
message,
&db,
validator.as_mut(),
sequencer.as_mut(),
network_sender.as_mut(),
);
if let Err(err) = result {
log::warn!("Failed to process network message: {:?}", err);
}

Consider to slash peer/validator which send such requests.

Possible Solution

Notes

No response

@grishasobol grishasobol added the C1-feature Feature request label Aug 21, 2024
@grishasobol
Copy link
Member Author

Also consider whether we should use log::error instead of log::warn in network request processing error case

@grishasobol grishasobol added the P2-sometimesoon Medium priority label Aug 21, 2024
@grishasobol grishasobol changed the title ethexe: slash peer/validator in case of network request errors ethexe: slash peer/validator in case of network request errors Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C1-feature Feature request P2-sometimesoon Medium priority
Projects
None yet
Development

No branches or pull requests

1 participant