refactor kube plugin's Action system #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up gdt-kube's execution of kube actions to pull all assertion evaluation up to the `Spec.Eval()` method. Functionally, the only difference this patch introduces is that retries are now performed in the `Spec.Eval()` method instead of only in the `Spec.doGet/doList()` methods. What this means is that all kube client calls, including Create, Delete and Apply, will be retried by default. Signed-off-by: Jay Pipes <[email protected]>
jaypipes
force-pushed
the
action-refactor
branch
from
c3fda54
to
7b994a0
Compare
a-hilaly
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up gdt-kube's execution of kube actions to pull all assertion evaluation up to the
Spec.Eval()method.Functionally, the only difference this patch introduces is that retries are now performed in the
Spec.Eval()method instead of only in theSpec.doGet/doList()methods. What this means is that all kube client calls, including Create, Delete and Apply, will be retried by default.Note this is precursor/required work for #1