Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gdsfactory #374

Merged
merged 4 commits into from
Apr 30, 2024
Merged

update gdsfactory #374

merged 4 commits into from
Apr 30, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Apr 27, 2024

  • update to latest gdsfactory

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @joamatab - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

docs/notebooks/11_sparameters.ipynb Outdated Show resolved Hide resolved
@joamatab joamatab added the dependencies Pull requests that update a dependency file label Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (64575f5) to head (866c570).

❗ Current head 866c570 differs from pull request most recent head 6415a81. Consider uploading reports for the commit 6415a81 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #374   +/-   ##
=======================================
  Coverage   68.80%   68.80%           
=======================================
  Files          19       19           
  Lines         763      763           
=======================================
  Hits          525      525           
  Misses        238      238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@joamatab joamatab merged commit ebf16ae into main Apr 30, 2024
4 of 5 checks passed
@joamatab joamatab deleted the update_gdsfactory725 branch April 30, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant