From 6b4a88775c6b8b44d3ee06040d122e5d7ac57be5 Mon Sep 17 00:00:00 2001 From: Joaquin Matres <4514346+joamatab@users.noreply.github.com> Date: Tue, 30 Apr 2024 11:32:00 -0700 Subject: [PATCH 1/3] update port_name --- .pre-commit-config.yaml | 2 +- pyproject.toml | 2 +- .../test_netlists_add_fiber_array_.yml | 1 + ...test_netlists_add_fiber_array_pads_rf_.yml | 1 + .../test_netlists_dbr_cavity_te_.yml | 1 + ubcpdk/components.py | 19 ++++++++++--------- 6 files changed, 15 insertions(+), 11 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index d0b731f5..9ef64982 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -20,7 +20,7 @@ repos: - tomli - repo: https://github.com/astral-sh/ruff-pre-commit - rev: "v0.4.1" + rev: "v0.4.2" hooks: - id: ruff args: [ --fix, --exit-non-zero-on-fix ] diff --git a/pyproject.toml b/pyproject.toml index 3943af0d..ea03096b 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -15,7 +15,7 @@ classifiers = [ "Operating System :: OS Independent" ] dependencies = [ - "gdsfactory==7.25.0", + "gdsfactory==7.25.1", "gplugins[tidy3d,sax,schematic]>=0.13,<0.14" ] description = "ubcpdk pdk" diff --git a/tests/test_netlists/test_netlists_add_fiber_array_.yml b/tests/test_netlists/test_netlists_add_fiber_array_.yml index ef8970de..5d20a9e1 100644 --- a/tests/test_netlists/test_netlists_add_fiber_array_.yml +++ b/tests/test_netlists/test_netlists_add_fiber_array_.yml @@ -20,6 +20,7 @@ instances: fanout_length: 0.0 gc_port_labels: null gc_port_name: o1 + gc_port_name_fiber: o2 get_input_label_text_function: function: get_input_label_text get_input_labels_function: diff --git a/tests/test_netlists/test_netlists_add_fiber_array_pads_rf_.yml b/tests/test_netlists/test_netlists_add_fiber_array_pads_rf_.yml index 4af468a2..034ba3ef 100644 --- a/tests/test_netlists/test_netlists_add_fiber_array_pads_rf_.yml +++ b/tests/test_netlists/test_netlists_add_fiber_array_pads_rf_.yml @@ -108,6 +108,7 @@ instances: fanout_length: 0.0 gc_port_labels: null gc_port_name: o1 + gc_port_name_fiber: o2 get_input_label_text_function: function: get_input_label_text get_input_labels_function: diff --git a/tests/test_netlists/test_netlists_dbr_cavity_te_.yml b/tests/test_netlists/test_netlists_dbr_cavity_te_.yml index 2d410c08..014c45fa 100644 --- a/tests/test_netlists/test_netlists_dbr_cavity_te_.yml +++ b/tests/test_netlists/test_netlists_dbr_cavity_te_.yml @@ -34,6 +34,7 @@ instances: fanout_length: 0.0 gc_port_labels: null gc_port_name: o1 + gc_port_name_fiber: o2 get_input_label_text_function: function: get_input_label_text get_input_labels_function: diff --git a/ubcpdk/components.py b/ubcpdk/components.py index 9e684f28..b2c7937e 100644 --- a/ubcpdk/components.py +++ b/ubcpdk/components.py @@ -237,7 +237,7 @@ def gc_te1310() -> gf.Component: name = prefix_te1310 c.add_port( name=name, - port_type=name, + port_type="vertical_te", center=(25, 0), layer=(1, 0), width=9, @@ -257,7 +257,7 @@ def gc_te1310_8deg() -> gf.Component: name = prefix_te1310 c.add_port( name=name, - port_type=name, + port_type="vertical_te", center=(25, 0), layer=(1, 0), width=9, @@ -277,7 +277,7 @@ def gc_te1310_broadband() -> gf.Component: name = prefix_te1310 c.add_port( name=name, - port_type=name, + port_type="vertical_te", center=(25, 0), layer=(1, 0), width=9, @@ -297,7 +297,7 @@ def gc_te1550() -> gf.Component: name = prefix_te1550 c.add_port( name=name, - port_type=name, + port_type="vertical_te", center=(25, 0), layer=(1, 0), width=9, @@ -317,7 +317,7 @@ def gc_te1550_90nmSlab() -> gf.Component: name = prefix_te1550 c.add_port( name=name, - port_type=name, + port_type="vertical_te", center=(25, 0), layer=(1, 0), width=9, @@ -337,7 +337,7 @@ def gc_te1550_broadband() -> gf.Component: name = prefix_te1550 c.add_port( name=name, - port_type=name, + port_type="vertical_te", center=(25, 0), layer=(1, 0), width=9, @@ -357,7 +357,7 @@ def gc_tm1550() -> gf.Component: name = prefix_tm1550 c.add_port( name=name, - port_type=name, + port_type="vertical_tm", center=(25, 0), layer=(1, 0), width=9, @@ -514,7 +514,6 @@ def add_fiber_array( ref.rotate(-90) c.add_ports(ref.ports) c.copy_child_info(component) - return c @@ -816,6 +815,7 @@ def add_pads( if __name__ == "__main__": c = straight_heater_metal() + c.pprint_ports() # c.pprint_ports() # c = straight() # c = uc.ring_single_heater() @@ -824,7 +824,7 @@ def add_pads( # c = ring_double(length_y=10) # c = ring_with_crossing() # c = mmi1x2() - # c = add_fiber_array(mzi) + c = add_fiber_array(straight_heater_metal) # c = coupler_ring() # c = dbr_cavity_te() # c = dbr_cavity() @@ -840,4 +840,5 @@ def add_pads( # c = ebeam_dc_halfring_straight() # c = ring_with_crossing() # c = ring_single() + c.pprint_ports() c.show(show_ports=False) From 3c340770c1903f2b1050c9834c002fc661dce713 Mon Sep 17 00:00:00 2001 From: Joaquin Matres <4514346+joamatab@users.noreply.github.com> Date: Tue, 30 Apr 2024 11:32:53 -0700 Subject: [PATCH 2/3] simpler readme --- README.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/README.md b/README.md index bf274592..4d90434b 100644 --- a/README.md +++ b/README.md @@ -2,9 +2,6 @@ [![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/gdsfactory/binder-sandbox/HEAD) [![pypi](https://img.shields.io/pypi/v/ubcpdk)](https://pypi.org/project/ubcpdk/) -[![issues](https://img.shields.io/github/issues/gdsfactory/ubc)](https://github.com/gdsfactory/ubc/issues) -![forks](https://img.shields.io/github/forks/gdsfactory/ubc) -![Stars](https://img.shields.io/github/stars/gdsfactory/ubc) [![mit](https://img.shields.io/github/license/gdsfactory/ubc)](https://choosealicense.com/licenses/mit/) [![codecov](https://codecov.io/gh/gdsfactory/ubc/branch/main/graph/badge.svg?token=T3kCV2gYE9)](https://codecov.io/gh/gdsfactory/ubc) [![black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/psf/black) From bdd15a9d41dcde6319bfe7e6ae5e652a3d53115e Mon Sep 17 00:00:00 2001 From: Joaquin Matres <4514346+joamatab@users.noreply.github.com> Date: Wed, 1 May 2024 10:11:09 -0700 Subject: [PATCH 3/3] update readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 4d90434b..9fc3be6c 100644 --- a/README.md +++ b/README.md @@ -28,7 +28,7 @@ Then you need to restart Klayout to make sure the new technology installed appea ### Installation for developers -For developers you need to `git clone` the GitHub repository, fork it, git add, git commit, git push and merge request your changes. +For developers you need to fork, `git clone` the GitHub repository, git add, git commit, git push and merge request your changes. ``` git clone https://github.com/gdsfactory/ubc.git