Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build code from gcla/tail only on Windows to allow Debian packaging #76

Closed
gcla opened this issue Dec 23, 2019 · 2 comments · Fixed by #77
Closed

Build code from gcla/tail only on Windows to allow Debian packaging #76

gcla opened this issue Dec 23, 2019 · 2 comments · Fixed by #77
Assignees
@dawidd6

Comments

@gcla
Copy link
Owner

gcla commented Dec 23, 2019

This is related to #74.

If we can ensure code from gcla/tail is only compiled on Windows (the only target for which it's needed), then gcla/tail won't need to be packaged for Debian, meaning termshark's Debian package can be updated.

CCing @dawidd6
@dawidd6
Copy link
Contributor

dawidd6 commented Dec 23, 2019

Can I try?

@gcla
Copy link
Owner Author

gcla commented Dec 23, 2019

Yeah absolutely, thanks! I'll assign it to you

@dawidd6 dawidd6 mentioned this issue Dec 23, 2019
Merged
@gcla gcla closed this as completed in #77 Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dawidd6 dawidd6

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use gcla/tail on Windows and tail command on unix dawidd6/termshark
2 participants
@gcla @dawidd6