Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Build #41

Merged
merged 6 commits into from
Mar 25, 2019
Merged

Update Build #41

merged 6 commits into from
Mar 25, 2019

Conversation

dfquaresma
Copy link
Member

This PR resolves #40.

Copy link
Contributor

@danielfireman danielfireman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não há nenhum arquivo do travis ou do coverallas para atualizar?

core/pom.xml Outdated Show resolved Hide resolved
@dfquaresma
Copy link
Member Author

dfquaresma commented Mar 25, 2019

Não há nenhum arquivo do travis ou do coverallas para atualizar?

Há, no arquivo travis.yml. Ele foi comentado em outro momento porque o jacoco estava problemático kk. Inclusive, o código permanece comentado para facilitar a issue #33 posteriormente. Por essa razão que comentei o código do jacoco do pom nessa PR.

@danielfireman
Copy link
Contributor

Por favor remova aqui e lá.

core/pom.xml Outdated
</goals>
</execution>
</executions>
</plugin>
<plugin>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esse plugin aqui? Não seria hora de remover?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bem notado. Foquei só no jacoco e esqueci do que estava associado a ele. Obrigado!

@dfquaresma dfquaresma merged commit 7d5ddf1 into master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update build.sh to include agent
2 participants