From 96c9987eb48770d618b9f9bd5950cd0046745a57 Mon Sep 17 00:00:00 2001
From: Matthew Blissett <matt@blissett.me.uk>
Date: Thu, 10 Oct 2024 14:34:22 +0200
Subject: [PATCH] Set default search path for PostgreSQL functions.

Resolves #525.
---
 .../liquibase/146-function-search-paths.xml   | 25 +++++++++++++++++++
 .../src/main/resources/liquibase/master.xml   |  1 +
 2 files changed, 26 insertions(+)
 create mode 100644 registry-persistence/src/main/resources/liquibase/146-function-search-paths.xml

diff --git a/registry-persistence/src/main/resources/liquibase/146-function-search-paths.xml b/registry-persistence/src/main/resources/liquibase/146-function-search-paths.xml
new file mode 100644
index 000000000..4c3ea9a0a
--- /dev/null
+++ b/registry-persistence/src/main/resources/liquibase/146-function-search-paths.xml
@@ -0,0 +1,25 @@
+<databaseChangeLog
+    xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-2.0.xsd">
+
+  <!-- Set the search paths to public. For security, VACUUM uses an empty search path and fails otherwise.
+       https://stackoverflow.com/questions/65237130/getting-function-does-not-exist-error-in-vacuumdb -->
+  <changeSet id="146" author="mblissett">
+    <sql>
+      ALTER FUNCTION collection_change_trigger SET search_path = public;
+      ALTER FUNCTION collection_contact_change_trigger SET search_path = public;
+      ALTER FUNCTION collection_descriptor_change_trigger SET search_path = public;
+      ALTER FUNCTION collection_descriptor_group_change_trigger SET search_path = public;
+      ALTER FUNCTION collection_descriptor_verbatim_change_trigger SET search_path = public;
+      ALTER FUNCTION contact_change_trigger SET search_path = public;
+      ALTER FUNCTION dataset_change_trigger SET search_path = public;
+      ALTER FUNCTION installation_change_trigger SET search_path = public;
+      ALTER FUNCTION institution_change_trigger SET search_path = public;
+      ALTER FUNCTION network_change_trigger SET search_path = public;
+      ALTER FUNCTION node_change_trigger SET search_path = public;
+      ALTER FUNCTION organization_change_trigger SET search_path = public;
+      ALTER FUNCTION normalize_name SET search_path = public;
+    </sql>
+  </changeSet>
+</databaseChangeLog>
diff --git a/registry-persistence/src/main/resources/liquibase/master.xml b/registry-persistence/src/main/resources/liquibase/master.xml
index dad5a9f8c..dd03f72f0 100644
--- a/registry-persistence/src/main/resources/liquibase/master.xml
+++ b/registry-persistence/src/main/resources/liquibase/master.xml
@@ -151,4 +151,5 @@
   <include file="liquibase/143-removed-fields-grscicoll.xml" />
   <include file="liquibase/144-mdt-endpoint-installation-types.xml" />
   <include file="liquibase/145-contact-salutation.xml" />
+  <include file="liquibase/146-function-search-paths.xml" />
 </databaseChangeLog>