From b81871ad15e9091f72344689c7ed8da9955859a6 Mon Sep 17 00:00:00 2001 From: fmendezh Date: Tue, 24 Sep 2024 13:03:54 +0200 Subject: [PATCH] https://github.com/gbif/pipelines/issues/1078 fixing it test, steps count --- .../org/gbif/pipelines/tasks/PipelinesCallbackIT.java | 8 ++++---- .../tasks/occurrences/hdfs/HdfsViewCallbackIT.java | 2 +- .../interpretation/InterpretationCallbackIT.java | 2 +- .../tasks/verbatims/abcd/AbcdToAvroCallbackIT.java | 4 ++-- .../tasks/verbatims/dwca/DwcaToAvroCallbackIT.java | 10 +++++----- .../tasks/verbatims/xml/XmlToAvroCallbackIT.java | 4 ++-- 6 files changed, 15 insertions(+), 15 deletions(-) diff --git a/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/PipelinesCallbackIT.java b/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/PipelinesCallbackIT.java index a1275dfcb1..bcd82fd7de 100644 --- a/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/PipelinesCallbackIT.java +++ b/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/PipelinesCallbackIT.java @@ -71,7 +71,7 @@ public void newFullIngestionCompletedTest() { // Should Map result = historyClient.getStepMap(); - Assert.assertEquals(6, result.size()); + Assert.assertEquals(7, result.size()); Assert.assertEquals(1, historyClient.getPipelineExecutionMap().size()); Assert.assertEquals(1, historyClient.getPipelineProcessMap().size()); @@ -138,7 +138,7 @@ public void newHalfIngestionCompletedTest() { // Should Map result = historyClient.getStepMap(); - Assert.assertEquals(4, result.size()); + Assert.assertEquals(5, result.size()); Assert.assertEquals(1, historyClient.getPipelineExecutionMap().size()); Assert.assertEquals(1, historyClient.getPipelineProcessMap().size()); @@ -242,7 +242,7 @@ public void newFullIngestionFailedTest() { // Should Map result = historyClient.getStepMap(); - Assert.assertEquals(6, result.size()); + Assert.assertEquals(7, result.size()); Assert.assertEquals(1, historyClient.getPipelineExecutionMap().size()); Assert.assertEquals(1, historyClient.getPipelineProcessMap().size()); @@ -329,7 +329,7 @@ public void twoStepsIngestionCompletedTest() { // Should Map result = historyClient.getStepMap(); - Assert.assertEquals(6, result.size()); + Assert.assertEquals(7, result.size()); Assert.assertEquals(1, historyClient.getPipelineExecutionMap().size()); Assert.assertEquals(1, historyClient.getPipelineProcessMap().size()); diff --git a/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/occurrences/hdfs/HdfsViewCallbackIT.java b/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/occurrences/hdfs/HdfsViewCallbackIT.java index 771c8c5ac8..1767af939b 100644 --- a/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/occurrences/hdfs/HdfsViewCallbackIT.java +++ b/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/occurrences/hdfs/HdfsViewCallbackIT.java @@ -78,7 +78,7 @@ public void successFullInterpretationTest() { assertTrue(path.toFile().exists()); Map result = historyClient.getStepMap(); - Assert.assertEquals(1, result.size()); + Assert.assertEquals(2, result.size()); Assert.assertEquals(1, historyClient.getPipelineExecutionMap().size()); Assert.assertEquals(1, historyClient.getPipelineProcessMap().size()); diff --git a/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/occurrences/interpretation/InterpretationCallbackIT.java b/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/occurrences/interpretation/InterpretationCallbackIT.java index a846a8445c..538203c713 100644 --- a/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/occurrences/interpretation/InterpretationCallbackIT.java +++ b/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/occurrences/interpretation/InterpretationCallbackIT.java @@ -161,7 +161,7 @@ public void invalidChildSystemProcessTest() { assertEquals(0, PUBLISHER.getMessages().size()); Map result = historyClient.getStepMap(); - Assert.assertEquals(4, result.size()); + Assert.assertEquals(5, result.size()); Assert.assertEquals(1, historyClient.getPipelineExecutionMap().size()); Assert.assertEquals(1, historyClient.getPipelineProcessMap().size()); diff --git a/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/verbatims/abcd/AbcdToAvroCallbackIT.java b/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/verbatims/abcd/AbcdToAvroCallbackIT.java index 4410daf52b..0fa2197686 100644 --- a/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/verbatims/abcd/AbcdToAvroCallbackIT.java +++ b/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/verbatims/abcd/AbcdToAvroCallbackIT.java @@ -112,7 +112,7 @@ public void normalCaseWhenFilesInDirectoryTest() throws Exception { assertEquals(1, PUBLISHER.getMessages().size()); Map result = historyClient.getStepMap(); - Assert.assertEquals(6, result.size()); + Assert.assertEquals(7, result.size()); Assert.assertEquals(1, historyClient.getPipelineExecutionMap().size()); Assert.assertEquals(1, historyClient.getPipelineProcessMap().size()); @@ -196,7 +196,7 @@ public void failedCaseWhenXmlAvroEmptyTest() { assertTrue(PUBLISHER.getMessages().isEmpty()); Map result = historyClient.getStepMap(); - Assert.assertEquals(6, result.size()); + Assert.assertEquals(7, result.size()); Assert.assertEquals(1, historyClient.getPipelineExecutionMap().size()); Assert.assertEquals(1, historyClient.getPipelineProcessMap().size()); diff --git a/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/verbatims/dwca/DwcaToAvroCallbackIT.java b/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/verbatims/dwca/DwcaToAvroCallbackIT.java index e3b71df49d..7ef95c282e 100644 --- a/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/verbatims/dwca/DwcaToAvroCallbackIT.java +++ b/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/verbatims/dwca/DwcaToAvroCallbackIT.java @@ -139,7 +139,7 @@ public void normalCaseTest() throws Exception { assertEquals(1, PUBLISHER.getMessages().size()); Map result = historyClient.getStepMap(); - Assert.assertEquals(6, result.size()); + Assert.assertEquals(7, result.size()); Assert.assertEquals(1, historyClient.getPipelineExecutionMap().size()); Assert.assertEquals(1, historyClient.getPipelineProcessMap().size()); @@ -216,7 +216,7 @@ public void csvCaseTest() throws Exception { assertEquals(1, PUBLISHER.getMessages().size()); Map result = historyClient.getStepMap(); - Assert.assertEquals(6, result.size()); + Assert.assertEquals(7, result.size()); Assert.assertEquals(1, historyClient.getPipelineExecutionMap().size()); Assert.assertEquals(1, historyClient.getPipelineProcessMap().size()); @@ -293,7 +293,7 @@ public void xlsxCaseTest() throws Exception { assertEquals(1, PUBLISHER.getMessages().size()); Map result = historyClient.getStepMap(); - Assert.assertEquals(6, result.size()); + Assert.assertEquals(7, result.size()); Assert.assertEquals(1, historyClient.getPipelineExecutionMap().size()); Assert.assertEquals(1, historyClient.getPipelineProcessMap().size()); @@ -448,7 +448,7 @@ public void normalSingleStepCaseTest() throws Exception { assertEquals(1, PUBLISHER.getMessages().size()); Map result = historyClient.getStepMap(); - Assert.assertEquals(6, result.size()); + Assert.assertEquals(7, result.size()); Assert.assertEquals(1, historyClient.getPipelineExecutionMap().size()); Assert.assertEquals(1, historyClient.getPipelineProcessMap().size()); @@ -524,7 +524,7 @@ public void failedCaseTest() { assertTrue(PUBLISHER.getMessages().isEmpty()); Map result = historyClient.getStepMap(); - Assert.assertEquals(6, result.size()); + Assert.assertEquals(7, result.size()); Assert.assertEquals(1, historyClient.getPipelineExecutionMap().size()); Assert.assertEquals(1, historyClient.getPipelineProcessMap().size()); diff --git a/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/verbatims/xml/XmlToAvroCallbackIT.java b/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/verbatims/xml/XmlToAvroCallbackIT.java index 333191cc99..f273ed7b1f 100644 --- a/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/verbatims/xml/XmlToAvroCallbackIT.java +++ b/gbif/coordinator/tasks-integration-tests/src/test/java/org/gbif/pipelines/tasks/verbatims/xml/XmlToAvroCallbackIT.java @@ -108,7 +108,7 @@ public void normalCaseWhenFilesInDirectoryTest() throws Exception { assertEquals(1, PUBLISHER.getMessages().size()); Map result = historyClient.getStepMap(); - Assert.assertEquals(6, result.size()); + Assert.assertEquals(7, result.size()); Assert.assertEquals(1, historyClient.getPipelineExecutionMap().size()); Assert.assertEquals(1, historyClient.getPipelineProcessMap().size()); @@ -184,7 +184,7 @@ public void failedCaseWhenXmlAvroEmptyTest() { assertTrue(PUBLISHER.getMessages().isEmpty()); Map result = historyClient.getStepMap(); - Assert.assertEquals(6, result.size()); + Assert.assertEquals(7, result.size()); Assert.assertEquals(1, historyClient.getPipelineExecutionMap().size()); Assert.assertEquals(1, historyClient.getPipelineProcessMap().size());